Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(chart): Loosen type for BaseChart.additionalSeries #87335

Merged
merged 1 commit into from
Mar 19, 2025
Merged

ref(chart): Loosen type for BaseChart.additionalSeries #87335

merged 1 commit into from
Mar 19, 2025

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Mar 18, 2025 •
edited
Loading

This can accept any ECharts series type, not just lines. Needed for #86946 where it'll be passed a CustomSeries

@billyvg
ref(chart): Loosen type for BaseChart.additionalSeries
e3c7f22 
This can accept any ECharts series type, not just lines. Needed for #86946
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 18, 2025
@billyvg billyvg marked this pull request as ready for review March 18, 2025 21:14
@billyvg billyvg requested a review from a team as a code owner March 18, 2025 21:14
@billyvg billyvg merged commit 34a86a0 into master Mar 19, 2025
43 checks passed
@billyvg billyvg deleted the ref-charts-loosen-base-chart-additional-series-type branch March 19, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gggritso gggritso gggritso approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billyvg @gggritso